On Thu, 11 May 2023 16:50:00 GMT, Alexey Ivanov <[email protected]> wrote:
> > The new version of the test fails for me on macOS because CTRL + DOWN key > > combination is reserved by the operating system. It is necessary to disable > > "Application windows" system key shortcut to execute the test without > > failure. > > Yes, it's known. It is recommended to disable all system shortcuts for > running client tests, see [the requirements on the > wiki](https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements#AutomatedclientGUItestingsystemsetuprequirements-macOS-SpecificSystemsetupnotes), > which may be unfeasible for a system one uses day-to-day. > > > An interesting thing is that the old version of the test works fine even if > > "Application windows" system key shortcut is enabled. > > It's because the old test didn't open that popup or didn't check its > position, I can't remember for sure. > > > I would suggest documenting (probably at testing.md/wiki page) that > > "Application windows" key shortcut should be disabled prior testing. > > It is already documented per the comment above. > > Do you also suggest changing the key stroke to another combination? Ah, I see. The previous version didn't cover all cases. It is up to author either to change the key stroke to another one or stay it as is. I am fine with the current version ------------- PR Comment: https://git.openjdk.org/jdk/pull/13578#issuecomment-1544387352
