> ViewportOverlapping test was failing intermittently during CI runs on Win10 > and Win11. > > Although this intermittent issue wasn't replicable when the individual test > as well as the test group was run multiple times, a defensive fix has been > applied. The fix is made to the base class -OverlappingTestBase.java, which > holds the common Standard Test Machinery for AWT_Mixing tests. > > `Toolkit.getDefaultToolkit().sync()` is added > `OverlappingTestBase.testComponent()`. I believe Thread.sleep(500) alone, > might not be sufficient to flush all the graphics events of this test on > slower systems which might be causing this test to fail intermittently during > CI runs. > > Screenshot capture has been added to ViewportOverlapping.java to aid > debugging this intermittent issue, in case it should occur again. > > PS: Only relevant code in OverlappingTestBase has been cleaned-up as required > by this test. There are other parts of the base class that require code > clean-up which is best if taken up as a separate issue as it has common code > across many AWT_Mixing tests.
Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: review fix ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14289/files - new: https://git.openjdk.org/jdk/pull/14289/files/9ebbecc3..b3bff669 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14289&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14289&range=00-01 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/14289.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14289/head:pull/14289 PR: https://git.openjdk.org/jdk/pull/14289
