On Tue, 6 Jun 2023 22:34:15 GMT, Phil Race <p...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review fix
>
> test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights
>> reserved.
>
> 2022 ?
This was by miss :)
Updated to 2023
> test/jdk/java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java line 164:
>
>> 162: OverlappingTestBase.doMain(args);
>> 163: captureScreen("Img_5.png");
>> 164: }
>
> It is just a test, so no need to over-engineer it but it 'feels wrong' to
> specify the file name
> as foo.png here and separately inside captureScreen choose 'png' as the file
> type to use.
> Perhaps captureScreen("Img_5.png", "png") ?
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14289#discussion_r1220502248
PR Review Comment: https://git.openjdk.org/jdk/pull/14289#discussion_r1220502673
