On Wed, 7 Jun 2023 14:21:08 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>>> This comparison could fail for the case where there's a space before the
>>> `%` in the string.
>>
>> `FontSize` does handle `{"font-size: 100%", "font-size: 100 %"}` pair, but
>> `LengthValue` doesn't.
>
> No, it doesn't. For some reason, both `100%` and `200%` are parsed so that
> `span = 1.0`.
>
> Let's leave it as is then. It handles the most common case.
>
> Handling a space before the percent sign can be postponed to a later fix.
Aha, the value is capped at 100%:
https://github.com/openjdk/jdk/blob/4683844d8a26b56c903f6a67aadb159c81c2a2b8/src/java.desktop/share/classes/javax/swing/text/html/CSS.java#L2627-L2628
This is why 200% is parsed as if it were 100%.
The following code
public boolean equals(Object val) {
return val instanceof CSS.LengthValue lu
&& percentage == lu.percentage
&& span == lu.span
&& Objects.equals(units, lu.units);
}
works correctly if you modify this line in the test
https://github.com/openjdk/jdk/blob/4683844d8a26b56c903f6a67aadb159c81c2a2b8/test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java#L86
to
{"margin-top: 100%", "margin-top: 50%"},
The above code also handles the case `"margin-top: 50 %"` correctly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1221932524
