On Thu, 8 Jun 2023 06:58:51 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>>> I had already made that observation in this >>> https://github.com/openjdk/jdk/pull/13405#discussion_r1213916093few days >>> back in case you overlooked >> >> I did miss this comment. Sorry about that. >> >> Even though space between the value and the percent sign or the units is >> invalid (I couldn't find it quickly in the W3C spec for CSS), you should >> compare the parsed values. We pass `100%` and `200%` but the parsed value is >> `100%` in both cases — **the attribute sets are indeed *equal***. If you >> apply either attribute set to a document, you'll get the same result. Does >> it make sense? >> >> There could be other cases where the computed/parsed values are the same >> even though the input is different, for example `"font-size: medium"` has a >> numeric value in points or pixels, so the attribute set with the same value >> should be equal, don't you agree? > > I am not sure on 100%, 200% ie >= 100% should be considered equal or not..I > could not find in spec...also the URL I gave has 200% as valid value...so as > of now I have considered what is normal and made `equals` return false for > different percentages irrespective of < or > 100%.. I also think that capping at 100% is wrong but it's another bug. Currently, both 100% and 200% result in attribute sets which behave as if both were 100%, therefore they should be equal. I strongly believe we should compare the parsed values not the input string. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1222563667
