On Thu, 15 Jun 2023 15:04:57 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>>> These don't seem to be part of the public API, so this is probably >>> deliberate and not a bug. >>> https://docs.oracle.com/javase/accessbridge/2.0.2/api.htm#jab-api-specification >> >> @prrace should non-public API methods be removed from .DEF then? > >> > These don't seem to be part of the public API, so this is probably >> > deliberate and not a bug. >> > https://docs.oracle.com/javase/accessbridge/2.0.2/api.htm#jab-api-specification >> >> @prrace should non-public API methods be removed from .DEF then? > > I think it's the best solution. These four functions are not part of the > public API to AccessBridge, they're missing from > [`AccessBridgeCalls.c`](https://github.com/openjdk/jdk/blob/master/src/jdk.accessibility/windows/native/bridge/AccessBridgeCalls.c) > and > [`AccessBridgeCalls.h`](https://github.com/openjdk/jdk/blob/master/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h). > > They should not be exported. If the functions aren't loaded by its name, > which is implemented in `AccessBridgeCalls.c`, or otherwise linked to from > other modules (`.exe` or `.dll`), they don't need to be exported. These > functions are part of the `WinAccessBridge` class, none of them cannot be > called directly. > > Did you try removing them from the `.def` file? Does anything break? @aivanov-jdk Compiles and works fine without the exports in .def ------------- PR Comment: https://git.openjdk.org/jdk/pull/13734#issuecomment-1593492047
