On Fri, 23 Jun 2023 14:24:44 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76: >> >>> 74: /*for multifont menu */ >>> 75: BOOL IsTopMenu(); >>> 76: virtual AwtMenuItem* GetItem(jobject target, int index); >> >> Hi @aivanov-jdk are you OK leaving this inconsistent with the definition? >> https://github.com/openjdk/jdk/blob/16b5a91461db1765e2e7596ebaaf1299cec9b0c8/src/java.desktop/windows/native/libawt/windows/awt_Menu.cpp#L261 > > The declaration and implementation have to match. To minimise the number of changes, we can go for using `jint` in `AwtMenu::GetItem`. What do you thing, @djelinski and @TheShermanTanker? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1239891473
