On Fri, 21 Jul 2023 19:42:00 GMT, Abhishek Kumar <[email protected]> wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return the correct accessible child from
>> getAccessibleChild method which is AquaComboBoxButton (arrowButton) instance
>> and that results in invoking the a11y APIs to return the current selected
>> item in combobox.
>>
>> Further when the application comes up first time the accessible name is not
>> set for current displayed item in JCombobox that is handled in
>> AquaComboBoxButton which will take care for the current selected item as
>> well as if user modifies the selection by drop-down list.
>>
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> bugid removed in comments
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java line
1131:
> 1129: switch ( i ) {
> 1130: case 0:
> 1131: if ( popup instanceof Accessible accessiblePopup) {
Suggestion:
if (popup instanceof Accessible accessiblePopup) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1272669170
