On Fri, 1 Sep 2023 06:05:09 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert BasicComboBoxUI fix and update review comment > > src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line > 253: > >> 251: >> 252: // set the accessible name to the displayed text in JComboBox. >> 253: // screen magnifier queries to get the accessible name to >> display magnified text. > > I still do not think that setting accessible name in paint is a good idea. > Setting it during the initialization and adding a property change listener to > the accessible context to track changes seems like a better way to do it. Ok, I will check this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1312790194
