On Tue, 1 Aug 2023 13:38:13 GMT, Alexey Ivanov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSeparatorUI.java
> line 162:
>
>> 160: else {
>> 161: return new Dimension(Integer.MAX_VALUE, d.height);
>> 162: }
>
> `WindowsToolBarSeparatorUI` uses `Short.MAX_VALUE` instead of `Interger`:
>
> https://github.com/openjdk/jdk/blob/ee3e0917b393b879a543060ace2537be84f20e82/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsToolBarSeparatorUI.java#L74-L81
>
> Should we follow the pattern here?
>
> In Java Code Style, the `else` keyword should be on the same line as the
> closing brace.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15054#discussion_r1281453945
