On Thu, 3 Aug 2023 03:23:56 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Adding buttons in a JToolBar after a JSeparator will push the button to the >> far right of the frame instead of just after the separator >> >>  >> >> This is because BasicSeparatorUI does not define a maximum size. This leads >> to the separator getting all the extra width. >> Fix is made to limit the separator's maximum size to the preferred size of >> corresponding orientation (i.e. width for VERTICAL and height for HORIZONTAL) > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Review comments Changes requested by aivanov (Reviewer). test/jdk/javax/swing/JToolBar/ToolBarSeparatorTest.java line 37: > 35: import java.awt.Insets; > 36: import java.awt.image.BufferedImage; > 37: import java.awt.Point; The updated code doesn't use four of these imports: Color, Dimension, Insets, Point. test/jdk/javax/swing/JToolBar/ToolBarSeparatorTest.java line 51: > 49: import javax.imageio.ImageIO; > 50: > 51: public class ToolBarSeparatorTest { Is `ToolBarSeparatorSizeTest` more specific? ------------- PR Review: https://git.openjdk.org/jdk/pull/15054#pullrequestreview-1560797655 PR Review Comment: https://git.openjdk.org/jdk/pull/15054#discussion_r1283007423 PR Review Comment: https://git.openjdk.org/jdk/pull/15054#discussion_r1283008007
