On Fri, 4 Aug 2023 12:41:52 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. >> Converting the `String `to `locale` before adding as command key fix the >> issue. >> I have verified the test in all other platforms and Look and Feel which has >> option to create New Folder, results were fine. No regressions found on CI >> system with the fix. Added manual test to verify the fix. > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1595: > >> 1593: String newFolderText = >> UIManager.getString(FilePane.ACTION_NEW_FOLDER, >> 1594: getFileChooser().getLocale()); >> 1595: putValue(Action.ACTION_COMMAND_KEY, newFolderText); > > I doubt this is the right thing to do. `ACTION_COMMAND_KEY` aren't > localisable as far as I can see, and it makes perfect sense — they identify > internal names of the commands. > > The tooltip of the command and the created folder name are localisable. > > If I run SwingSet2 in German locale, it works as expected: the tooltip of the > New folder command is displayed in German (as the entire interface of > `JFileChooser`) and the created folder has German name. > > Start SwingSet2 with this command: > > > java -Duser.language=de -Duser.country=DE -jar /SwingSet2.jar I can see French resource files: [`windows_fr.properties`](https://github.com/openjdk/jdk/blob/e8a37b90db8dca4dc3653970b2d66d2faf8ef452/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties); the resources may not be included in the built JDK though. I remember translations were removed, some were added back later. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15069#discussion_r1284395814
