On Wed, 9 Aug 2023 06:01:47 GMT, Tejesh R <t...@openjdk.org> wrote:

>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. 
>> Converting the `String `to `locale` before adding as command key fix the 
>> issue. 
>> I have verified the test in all other platforms and Look and Feel which has 
>> option to create New Folder, results were fine. No regressions found on CI 
>> system with the fix. Added manual test to verify the fix.
>
> Tejesh R has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Proposed Fix

Re-opening the PR with proposed fix. After understanding the issue reported and 
analysis made, it is observed that on change of locale (mid-application) all 
others component labels were update with new locale provided, yet `New Folder` 
didn't. So if changing Locale mid-application is accepted, then updating the 
two fields `newFolderString` and `newFolderNextString` in 
`WindowsFileSystemView` class is required. (Yet other OS classes to be updated 
too)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15069#issuecomment-1670724020

Reply via email to