On Mon, 25 Sep 2023 20:23:27 GMT, Alexander Zvegintsev <azveg...@openjdk.org> 
wrote:

>> test/jdk/javax/swing/JFrame/DefaultCloseOperation.java line 78:
>> 
>>> 76:          -  Select "Dispose" from the "JDialog Default Close Operation" 
>>> ComboBox
>>> 77:          -  On the TestDialog, select "Close" from the system menu (the 
>>> window should go away)
>>> 78:         """;
>> 
>> I guess this test should disable Pass and Fail buttons. The Fail button 
>> should remain disabled: the test will fail automatically. Yet the Pass 
>> button may always be enabled, or it could be enabled only after the tester 
>> cycles through all the scenarios.
>
> I think it's fine the way it is now. Just in case the user sees some unusual 
> failure.

Well, yes… I haven't thought about it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15827#discussion_r1337332580

Reply via email to