On Mon, 25 Sep 2023 15:45:59 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review comments
>
> test/jdk/java/awt/Frame/DefaultSizeTest.java line 42:
> 
>> 40:             and should be the minimum size allowed by the window manager.
>> 41:             For any WM, the frame should be very small.
>> 42:             When the test is complete, click Pass or Fail as appropriate.
> 
> I guess we can't determine the minimum size, yet it's a bit confusing.
> 
> Reading [JDK-4033151](https://bugs.openjdk.org/browse/JDK-4033151) reveals 
> the frame remained invisible on Solaris 2.5 and appeared in virtual desktop 
> with a large size.
> 
> Being more specific could still help: If the frame is not large, click Pass 
> or Fail otherwise.
> 
> This test would benefit from screenshots.

Submitted [JDK-8317112](https://bugs.openjdk.org/browse/JDK-8317112): Add 
screenshot for Frame/DefaultSizeTest.java.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15827#discussion_r1338874735

Reply via email to