On Mon, 9 Oct 2023 14:38:27 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove declaration changes which are not required >> - suggested by djelinski > > src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 218: > >> 216: static GtkWidget* (*fp_gtk_menu_bar_new)(); >> 217: static GtkWidget* (*fp_gtk_menu_item_new)(); >> 218: static GtkWidget* (*fp_gtk_notebook_new)(void); > > This change is inconsistent with the surrounding style; I'd keep the original > declaration, and only remove the NULL in function calls. I did not notice it is not required to change the prototype. OK, it works without this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16092#discussion_r1350418413
