On Tue, 10 Oct 2023 20:37:07 GMT, Phil Race <p...@openjdk.org> wrote:
>> src/java.desktop/unix/native/common/awt/awt_GraphicsEnv.h line 53: >> >>> 51: #define MITSHM_PERM_OWNER (0600) >>> 52: >>> 53: extern int XShmQueryExtension(Display* dpy); >> >> I wonder if it's even needed here: the declaration should come from >> `X11/extensions/XShm.h` which is included. > > I agree, but I wonder why it was ever added ? Near as I can tell its been > there since the SHM code was added in 1.4 So I have removed the declaration. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16092#discussion_r1354546381