On Fri, 13 Oct 2023 07:50:17 GMT, ScientificWare <[email protected]> wrote:
>> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.openjdk.java.net/browse/JDK-8292276) >> >> Adds missing color names, defined by CSS Level 4, in CSS.java : >> CSS Color Module Level 4 >> W3C Candidate Recommendation Snapshot, 5 July 2022 >> [7.1 Named Colors](https://www.w3.org/TR/css-color-4/#named-color) >> >> Designed from : [ScientificWare JDK-8292276 : Add named colors from CSS >> Color Module Level 4](https://github.com/scientificware/jdk/issues/12) > > ScientificWare has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 59 commits: > > - Merge master > - CSS.java : > - Update source code declaration in documentation comments and > specifications. > - Typo in an argument. > - MissingColorNames.java : > - Catches the Color Illegal Argument Exception and appends it to the > result summary. > - Uncomments rgb tests. > - MissingColorNames.java : > - Rename the color which doesn't belong to CSS-COLOR-4 specification. > - Merge master > - MissingColorNames.java : > - Add a subset of RGB and RGBA tests. > - MissingColorNames.java : > - rename the list of string test. > > CSS.java : > - correct a wrong index. > - MissingColorNames.java : Adds a subset of hexadecimal tests. > - Merge scientificware-patch-003-CSS-add_4_8_digits_hex_coded_color > > # Conflicts: > # src/java.desktop/share/classes/javax/swing/text/html/CSS.java > - Merge master > - ... and 49 more: https://git.openjdk.org/jdk/compare/1082c0e7...9898fedf I'm testing the change as is, results TBD but there are few things to be updated here. src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line 1029: > 1027: * functions</a></li> > 1028: * </ul> > 1029: * as specified by the <a > href="https://www.w3.org/TR/css-color-4/";>CSS Color Module Level 4</a>. Since this PR : https://github.com/openjdk/jdk/pull/13360/files We have the new {@spec .. } tag whereever we reference an external spec. So you should add it here too. test/jdk/javax/swing/text/html/CSS/Hex3468DigitsColor.java line 39: > 37: StringBuilder result = new StringBuilder(); > 38: boolean passed = true; > 39: StyleSheet styleSheet = new StyleSheet(); The MissingColorNames test makes this one look very sparse. can we please cover all the supported patterns and have negative tests too. ------------- Changes requested by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/9825#pullrequestreview-1690955680 PR Review Comment: https://git.openjdk.org/jdk/pull/9825#discussion_r1367520231 PR Review Comment: https://git.openjdk.org/jdk/pull/9825#discussion_r1367520708
