On Fri, 20 Oct 2023 22:12:29 GMT, Phil Race <[email protected]> wrote:
>> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 59 commits: >> >> - Merge master >> - CSS.java : >> - Update source code declaration in documentation comments and >> specifications. >> - Typo in an argument. >> - MissingColorNames.java : >> - Catches the Color Illegal Argument Exception and appends it to the >> result summary. >> - Uncomments rgb tests. >> - MissingColorNames.java : >> - Rename the color which doesn't belong to CSS-COLOR-4 specification. >> - Merge master >> - MissingColorNames.java : >> - Add a subset of RGB and RGBA tests. >> - MissingColorNames.java : >> - rename the list of string test. >> >> CSS.java : >> - correct a wrong index. >> - MissingColorNames.java : Adds a subset of hexadecimal tests. >> - Merge scientificware-patch-003-CSS-add_4_8_digits_hex_coded_color >> >> # Conflicts: >> # src/java.desktop/share/classes/javax/swing/text/html/CSS.java >> - Merge master >> - ... and 49 more: https://git.openjdk.org/jdk/compare/1082c0e7...9898fedf > > src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line > 1029: > >> 1027: * functions</a></li> >> 1028: * </ul> >> 1029: * as specified by the <a >> href="https://www.w3.org/TR/css-color-4/";>CSS Color Module Level 4</a>. > > Since this PR : https://github.com/openjdk/jdk/pull/13360/files > We have the new {@spec .. } tag whereever we reference an external spec. > So you should add it here too. Also, I think that in the public class doc of CSS.java which talks about CSS1, you need to add a comment "Additionally, the color strings from CSS 4 are supported" and again point to the spec. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/9825#discussion_r1367522765
