Re: RFR: JDK-8318955: Add ReleaseIntArrayElements in Java_sun_awt_X11_XlibWrapper_SetBitmapShape XlbWrapper.c to early return [v2]

[Phil Race]

On Mon, 30 Oct 2023 09:15:00 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

>> There is an early return in Java_sun_awt_X11_XlibWrapper_SetBitmapShape 
>> XlbWrapper.c that seems to miss a ReleaseIntArrayElements call.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add JNU_ThrowOutOfMemoryError

src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c line 2303:

> 2301:     if (!pRect) {
> 2302:         (*env)->ReleaseIntArrayElements(env, bitmap, values, JNI_ABORT);
> 2303:         JNU_ThrowOutOfMemoryError(env, "malloc failed");

I think the throw is unnecessary. You will get some incorrect rendering, but 
that's all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16392#discussion_r1376781142