On Mon, 30 Oct 2023 20:45:37 GMT, Phil Race <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add JNU_ThrowOutOfMemoryError
>
> src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c line 2303:
>
>> 2301: if (!pRect) {
>> 2302: (*env)->ReleaseIntArrayElements(env, bitmap, values,
>> JNI_ABORT);
>> 2303: JNU_ThrowOutOfMemoryError(env, "malloc failed");
>
> I think the throw is unnecessary. You will get some incorrect rendering, but
> that's all.
So should I remove the JNU_ThrowOutOfMemoryError ? The calloc in the same
file has a JNU_ThrowOutOfMemoryError (but maybe the situation is different
there?) .
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16392#discussion_r1377191445
