On Fri, 10 Nov 2023 11:58:19 GMT, Alexey Ivanov <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> jtreg update
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line
> 276:
>
>> 274: name = c.getAccessibleContext().getAccessibleName();
>> 275: }
>> 276: }
>
> For the button, super usually returns `""` (empty string) which is the
> default caption of the button. This code preserves the common behaviour of
> `getAccessibleName`, in particular it returns `accessibleName` field if it's
> set.
>
> Since the arrow button is an internal component, we may drop calling `super`.
> However, I'm unsure about it.
>
> The two `if` statements could be combined into one:
>
>
> if ((name == null || name.isEmpty())
> && (!comboBox.isEditable() && comboBox.getSelectedItem() !=
> null)) {
Conditions combined.
> Since the arrow button is an internal component, we may drop calling super.
> However, I'm unsure about it.
I think we can keep this as it is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1389729338
