On Tue, 21 Nov 2023 08:42:43 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> JProgressBar is always painted with border irrespective of the value set via
>> the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF.
>> Proposed fix is to add a check before painting the component.
>>
>> CI jobs are green after the fix. Links attached to JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review fix
test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 73:
> 71: ImageIO.write(withoutBorder, "png", new
> File("withoutBorder.png"));
> 72: throw new RuntimeException("JProgressBar border is
> painted when border\n" +
> 73: " painting is set to false");
Suggestion:
throw new RuntimeException("JProgressBar border is painted when
border " +
"painting is set to false");
You should probably remove the line break from the error message.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16467#discussion_r1400919095
