On Wed, 22 Nov 2023 03:27:01 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 28: >> >>> 26: import java.lang.reflect.InvocationTargetException; >>> 27: import java.awt.Graphics; >>> 28: import java.awt.image.BufferedImage; >> >> IDEA at my end disagrees with the current sorting order: >> Suggestion: >> >> import java.awt.Graphics; >> import java.awt.image.BufferedImage; >> import java.io.File; >> import java.io.IOException; > > I know that the sorting order is not correct but I received a comment on my > other PR https://github.com/openjdk/jdk/pull/16674#discussion_r1394632505 > which suggests `it is long standing convention that the "core" > packages (easily distinguished these days as those in the java.base module) > are listed before the desktop / AWT / Swing ones.` That's the reason I didn't > sorted the imports. > I know that the sorting order is not correct but I received a comment on my > other PR [#16674 > (comment)](https://github.com/openjdk/jdk/pull/16674#discussion_r1394632505) > which suggests `it is long standing convention that the "core" packages > (easily distinguished these days as those in the java.base module) are listed > before the desktop / AWT / Swing ones.` That's the reason I didn't sorted the > imports. Let us [discuss it there](https://github.com/openjdk/jdk/pull/16674#discussion_r1402059540). This is news to me. I am for sorting the imports alphabetically — an IDE does it perfectly and inserts new imports into the correct place, managing the list of imports manually is *tedious* and error-prone. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16467#discussion_r1402090399
