On Tue, 13 Feb 2024 04:49:28 GMT, Renjith Kannath Pariyangad <rkannathp...@openjdk.org> wrote:
>> Hi Reviewers, >> I have updated the test with 'PassFailJFrame' with programmatically >> generating image and print , please review and let me know your suggestions. > > Renjith Kannath Pariyangad has updated the pull request incrementally with > one additional commit since the last revision: > > Replaced skipped exception with runtime exception Looks good except for minor comment: remove `/test/lib` from the libraries. test/jdk/java/awt/PrintJob/ImageTest/ImageTest.java line 44: > 42: * @bug 4242308 4255603 > 43: * @key printer > 44: * @library /java/awt/regtesthelpers /test/lib Suggestion: * @library /java/awt/regtesthelpers The `/test/lib` library isn't used any more. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17790#pullrequestreview-1883139346 PR Review Comment: https://git.openjdk.org/jdk/pull/17790#discussion_r1491217984
