On Tue, 27 Feb 2024 11:04:05 GMT, Alexey Ivanov <[email protected]> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove system property set
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java
>  line 85:
> 
>> 83: 
>> 84:         textArea = new JTextArea();
>> 85:         frame.getContentPane().add(textArea);
> 
> Suggestion:
> 
>         frame.getContentPane().add(new JScrollPane(textArea));
> 
> Put the text area into a scroll pane to allow viewing all text even it 
> doesn't fit. And the messages with `ActionEvent` do not fit.

@alisenchung The ActionEvent messages are not seen in the "Event Message 
Display" window with the current changes. 
The textArea should be added to JScrollPane as @aivanov-jdk suggested and not 
as `spane.add(textArea)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1505200400

Reply via email to