On Tue, 12 Mar 2024 19:37:55 GMT, Alexander Zvegintsev <[email protected]>
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
>
>> 1336: if (panelCreator != null) {
>> 1337: if (splitUI && (testWindows != null ||
>> windowListCreator != null)) {
>> 1338: // TODO Is it required? We can support both
>
> @aivanov-jdk please note, I am going to remove this check, it looks
> artificial to me.
>
> In this test I added a JTextArea to display logs and messages.
> It looks like we could add similar functionality to PassFailJFrame (outside
> the scope of this issue, of course).
This looks like a valid scenario where testUI as well as splitUI are required
to be used in combination. Making this change to PassFailJFrame can be helpful.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1522311897
