On Wed, 13 Mar 2024 15:51:21 GMT, Alexey Ivanov <[email protected]> wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
>>
>>> 1336: if (panelCreator != null) {
>>> 1337: if (splitUI && (testWindows != null ||
>>> windowListCreator != null)) {
>>> 1338: // TODO Is it required? We can support both
>>
>> @aivanov-jdk please note, I am going to remove this check, it looks
>> artificial to me.
>>
>> In this test I added a JTextArea to display logs and messages.
>> It looks like we could add similar functionality to PassFailJFrame (outside
>> the scope of this issue, of course).
>
> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I
> decided it was safer to add this.
>
> Please, don't modify `PassFailJFrame` together with tests unless it's
> strictly required… It is for the sake of facilitating backporting the
> changes. Otherwise, backporting improvements to the framework will depend on
> the presence of a test.
>
> In this case, it could be fine though… provided that the test you're updating
> exists in all the repos.
>
> Either way, I think it's good to create a separate bug for `PassFailJFrame`
> which you'll resolve with the current one.
That's a good point, I created #18281 for that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1523619919
