On Wed, 13 Mar 2024 22:04:00 GMT, Phil Race <[email protected]> wrote:
>> Alexey Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. > > test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 97: > >> 95: .testTimeOut(8) >> 96: .rows(25) >> 97: .columns(70) > > Personally I like rows+columns to immediately follow instructions, > but I'll approve anyway and let you decide. I haven't changed these lines, only indentation is changed because I moved it into `try` block. I prefer keeping it as is so that these lines are attributed to Lawrence who modified the lines when he introduced the builder. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18224#discussion_r1524700032
