On Fri, 15 Mar 2024 13:11:06 GMT, Alexey Ivanov <[email protected]> wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 406: >> >>> 404: rows, columns, >>> 405: enableScreenCapture, >>> 406: false, 0), >> >> It is intentionally added only to the builder to avoid excessive changes to >> all constructors. >> >> It seems that the builder produces much cleaner code, so we probably >> shouldn't spend our time to changing a bunch of `PassFailJFrame` >> constructors, and at some point we can make the builder the only option >> available. > > Right. We should deprecate all the constructors, or rather remove them > altogether and update tests which use them. At this moment, there are 32 > tests which use `PassFailJFrame` constructors explicitly. > > I submitted [JDK-8328274](https://bugs.openjdk.org/browse/JDK-8328274): > _Remove PassFailJFrame constructors in favour of Builder_. > > Feel free to re-assign and implement it. If we remove the constructors, the builder object can be passed thus eliminating the need to add more parameters. So, it's a good thing to do. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526271182
