On Fri, 15 Mar 2024 15:21:23 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> It could be obvious from the usage… so we may skip the header altogether… if >> it's mentioned in the instructions, which should still be mentioned to let >> the test know they need to look for the messages. > >> Placeholder text isn't supported by Swing natively, is it? Therefore, >> you'll have to remove the placeholder text when you add the first message, >> which complicates logging a message. > > It is not a big overhead, e.g. I already did it by slightly changing the > `log()` method. `logClear()` and `logSet()` are untouched. Yep, I see it. I'm still inclined for going without the header or placeholder. Handling the placeholder text converts a one-liner into six lines of code. And I'm unsure the placeholder improves the tester experience… I may be overthinking… in which case *no header* and *no placeholder* seem a better option. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526467731
