On Sat, 16 Mar 2024 00:44:12 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixes based on review feedback > > test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 34: > >> 32: import javax.swing.JPanel; >> 33: >> 34: /** > > Suggestion: > > /* Done. > test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 56: > >> 54: frame.getContentPane().add(layeredPane); >> 55: frame.pack(); >> 56: frame.setVisible(true); > > frame.setVisible(true) can be removed, this avoid the test pane to appear > initially at a different location and then switch the final location, > additionally PassFailJFrame handles it. Fixed. > test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 85: > >> 83: .title("Overlapping Panels Cursor Test Instructions") >> 84: .instructions(instructions) >> 85: .rows(4) > > May be 5-6 rows looks better for the instruction length. > Using the below format avoids the need to specify a hardcoded row count > number :) > > Suggestion: > > .rows((int) instructions.lines().count() + 1) Ok. > test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 91: > >> 89: .awaitAndCheck(); >> 90: } >> 91: } > > EOF newline missing. Added new line ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527725691 PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527724615 PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527724519 PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1527724792