On Mon, 18 Mar 2024 08:24:31 GMT, Abhishek Kumar <[email protected]> wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes based on review feedback
>
> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 37:
>
>> 35: * @test
>> 36: * @bug 8007155
>> 37: * @summary [macosx] Disabled panel takes mouse input in JLayeredPane
>
> Is the test exclusive for MacOS?
No, the bug was found on MacOS but the test is valid for all operating systems.
> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 41:
>
>> 39: * @build PassFailJFrame
>> 40: * @run main/manual CursorOverlappedPanelsTest
>> 41: */
>
> May add a blank line after this.
Ok
> test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 45:
>
>> 43: public static JFrame initialize() {
>> 44: final JFrame frame = new JFrame("Overlapping Panels Cursor
>> Test");
>> 45: frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>
> frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); redundant, can be
> removed.
Ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528995686
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528995917
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528996362
