On Fri, 15 Mar 2024 05:06:23 GMT, Alexander Zvegintsev <[email protected]>
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review changes
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:
>
>> 65: .rows(15)
>> 66: .columns(40)
>> 67: .testUI(new MemoryLeak())
>
> It currently creates the MemoryLeak(aka Frame) on the main thread, instead of
> EDT.
>
> Suggestion:
>
> .testUI(MemoryLeak::new)
Completely missed this. Thanks!
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 77:
>
>> 75: Thread.sleep(300000);
>> 76: } catch (InterruptedException e) {
>> 77: if (!Globals.testPassed) {
>
> It looks like `Globals.testPassed` is never changed, so the test will always
> fail.
> Shouldn't this be controlled by the PassFailJFrame Pass/Fail buttons?
Good point. Removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529062753
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529062212
