On Mon, 18 Mar 2024 18:37:37 GMT, Damon Nguyen <[email protected]> wrote:
>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to
>> main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review changes
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 27:
> 25: * @bug 4078566 6658398
> 26: * @library /java/awt/regtesthelpers
> 27: * @build PassFailJFrame
How about we add @requires os.family == "linux" additionally here?
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:
> 40: private static final String INSTRUCTIONS =
> 41: """
> 42: Do the following steps on Solaris only.
Since the test can be run on Unix platforms, how about including it in the
instructions.
Suggestion:
Do the following steps on Unix platforms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1531261051
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1531266744
