On Tue, 19 Mar 2024 15:18:24 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
>> Alexander Zuev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java
>>
>> Co-authored-by: Aleksandr Zvegintsev
>> <77687766+azveg...@users.noreply.github.com>
>> - Make test skip if current toolkit is not supported;
>> Make test pass or fail automatically;
>> Correct test instructions accordingly;
>
> test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 93:
>
>> 91: 1) Click on 'Show File Dialog' button. A file dialog
>> will come up.
>> 92: 2) Double-click on '$clickDirName' and click OK.
>> 93: 3) The text in the text field will indicate if test is
>> passed or failed.
>
> It looks like we can remove the text field and its output altogether, and use
> `PassFailJFrame#forcePass`, `PassFailJFrame#forceFail` to finish the test.
Fixed.
> test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 100:
>
>> 98: instructions = """
>> 99: The test is not applicable for $toolkit. Press Pass.
>> 100: """. replace("$toolkit", toolkit);
>
> There is no point in showing the instruction window in this case, it is
> probably better to just throw the `jtreg.SkippedException`.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531087880
PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531089773
