On Tue, 19 Mar 2024 23:17:04 GMT, Alexander Zvegintsev <[email protected]> wrote:
>> Alexander Zuev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update test/jdk/java/awt/FileDialog/FileNameOverrideTest.java >> >> Co-authored-by: Aleksandr Zvegintsev >> <[email protected]> >> - Make test skip if current toolkit is not supported; >> Make test pass or fail automatically; >> Correct test instructions accordingly; > > test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 49: > >> 47: private final static String clickDirName = "Directory for double >> click"; >> 48: private final static String dirPath = >> System.getProperty("user.dir");; >> 49: private static JButton showBtn; > > Can be local variable Fixed. > test/jdk/java/awt/FileDialog/FileNameOverrideTest.java line 56: > >> 54: showBtn.addActionListener(w -> { >> 55: Frame frame = new Frame(); >> 56: fd = new FileDialog(frame, "Open"); > > Suggestion: > > fd = new FileDialog((Frame) null, "Open"); > > There is no point in this frame. Ok. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531541505 PR Review Comment: https://git.openjdk.org/jdk/pull/18365#discussion_r1531541438
