On Fri, 22 Mar 2024 15:31:48 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed the forcePass logic, updated instructions > > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 52: > >> 50: <body> >> 51: This test is relevant on platforms with high-resolution >> mouse wheel, >> 52: please press PASS if this is not the case.<br> <br> > > It may be worth mentioning that trackpad will suit too. Updated. > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 69: > >> 67: >> 68: Check if the test works OK when the mouse wheel is rotated >> very slow.<br> <br> >> 69: This is a semi-automated test, if you are using a hi-res >> mouse and > > I would move this paragraph above. At this moment, it's more important to say > that the test will pass automatically than that the tester needs to look > through the log of events. So, the sentence above could be removed altogether. Updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535891353 PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1535890462
