On Mon, 25 Mar 2024 16:55:35 GMT, Alisen Chung <[email protected]> wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> test instructions
test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:
> 41: .title("Test6977726")
> 42: .instructions("Check that there is a panel with white
> text " +
> 43: "titled \"Preview\" in the JColorChooser.")
> Check that there is a panel with white text titled "Preview" in the
> JColorChooser.
I read it as if the text should be titled "Preview", although it should
actually refer to the panel(maybe I'm wrong).
Since you modified the original "If you don't see the preview panel" by adding
the "white text" check, you should check it on all platforms/LaFs that this
text is really white and distinguishable from the background, otherwise it
might come back to us one day with a failure of this test.
test/jdk/javax/swing/JColorChooser/Test6977726.java line 46:
> 44: .rows(5)
> 45: .columns(40)
> 46: .testTimeOut(10)
Suggestion:
10 minutes seems too long for such a simple test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1538075544
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1538080488
