On Mon, 25 Mar 2024 18:43:44 GMT, Alexander Zvegintsev <[email protected]>
wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test instructions
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 43:
>
>> 41: .title("Test6977726")
>> 42: .instructions("Check that there is a panel with white
>> text " +
>> 43: "titled \"Preview\" in the JColorChooser.")
>
>> Check that there is a panel with white text titled "Preview" in the
>> JColorChooser.
>
> I read it as if the text should be titled "Preview", although it should
> actually refer to the panel(maybe I'm wrong).
>
> Since you modified the original "If you don't see the preview panel" by
> adding the "white text" check, you should check it on all platforms/LaFs that
> this text is really white and distinguishable from the background, otherwise
> it might come back to us one day with a failure of this test.
When I wrote it I meant to say "Check that there is a panel (with white text)
titled 'Preview'", but now that I read it again it is pretty unclear..
Does
`Check that there is a panel with "Text Preview Panel" text and with title
"Preview" in the JColorChooser.`
make more sense?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1540098175
