On Wed, 3 Apr 2024 08:38:38 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test update
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java
> line 351:
>
>> 349: Color caretColor = table.getColor("caretColor");
>> 350: Color controlText = table.getColor("controlText");
>> 351: Color tabbedPaneBg = new Color(238, 238, 238);
>
> Shouldn't it be ColorUIResource?
Updated.
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java
> line 776:
>
>> 774:
>> 775: // fill content area rect for both GTK and Nimbus LAF here
>> 776: g.fillRect(x, y, w, h);
>
> shouldn't it be within if block as is done in BasicTabbedPaneUI so that we
> fill only if it's opaque
Yes.. updated now.
> test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 56:
>
>> 54: private static final String INSTRUCTIONS = """
>> 55: The background color of panel (which contains the tabbed pane
>> 56: is green.
>
> instructions formatting needed..lot of empty spaces in the instruction
> dialog...
Updated now... seems ok to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1551025037
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1551025218
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1551025490
