On Thu, 4 Apr 2024 12:04:12 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> Abhishek Kumar has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review comment update
>
> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 21653:
> 
>> 21651:                <uiProperty name="useBasicArrows" type="BOOLEAN" 
>> value="true"/>
>> 21652:                <uiProperty name="contentOpaque" type="BOOLEAN" 
>> value="true"/>
>> 21653:                <uiProperty name="contentAreaColor" type="COLOR">
> 
> SInce you are introducing those 3 property in NimbusLookANdFeel, is this 
> defines needed in skin.laf?

I am not sure about this. Should I add them in skin.laf ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1551585863

Reply via email to