On Fri, 5 Apr 2024 18:22:18 GMT, Damon Nguyen <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JComboBox/DisabledComboBoxFontTestAuto.java line 144:
>
>> 142: }
>> 143: }
>> 144: System.out.println("Test Passed: "+lafName);
>
> Suggestion:
>
> System.out.println("Test Passed: " + lafName);
Updated.
> test/jdk/javax/swing/JComboBox/DisabledComboBoxFontTestAuto.java line 150:
>
>> 148: int redDiff = c1.getRed() - c2.getRed();
>> 149: int blueDiff = c1.getBlue() - c2.getBlue();
>> 150: int greenDiff = c1.getGreen() - c2.getGreen();
>
> Does this need Math.abs to get the absolute value of the difference?
That makes sense. Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18644#discussion_r1554206941
PR Review Comment: https://git.openjdk.org/jdk/pull/18644#discussion_r1554209216
