On Fri, 5 Apr 2024 19:47:23 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th >> reason behind this issue was the size of image which is different and that >> results in incorrect pixel comparison. Fix is to ensure that correct pixel >> is matched and the pixel color should remain within tolerance. >> For windows LAF the background color is not an exact match and thus added a >> TOLERANCE field to check if the RGB difference is within limits. >> >> `@key headful` added in jtreg tag to ensure that test run for GTK LAF as >> well which was not the case before as it is mentioned in JBS `It does not >> fail in mach5 because on linux + headless mode the gtk L&F is not supported.` >> >> CI testing is green for the modified test. Link attached in JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Review comment update Changes look good to me now. ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/18644#pullrequestreview-1984257082
