On Fri, 19 Apr 2024 00:58:00 GMT, Harshitha Onkar <[email protected]> wrote:
> Tested on Ubuntu, changes look good. > > Minor: Test instructions can be rephrased for clarity. Copyright years need > to be updated for some of source code files. Updated. > test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 83: > >> 81: - Select the 'content opaque' and check that content area >> is opaque >> 82: (it must be gray). >> 83: Check this behaviour for other LAFs and tab layout. > > @kumarabhi006 Click to check box 'content opaque' might seem unclear, whether > the checkbox needs to be checked or unchecked. It is better to replace it > with phrases - "checked/unchecked" or "select/unselect" as below. > > Same applies to Case 1 and Case 3. > > > Test Case 2 - Test Content pane opacity: > To test Content pane opacity, make sure "Opaque checkbox" is UNCHECKED. > > Verify the following with 'content opaque' option: > - when checked: the content area should be opaque (it must be gray). > - when unchecked: the content area should be transparent (it must be green). > > Check this behavior for other LAFs and tab layout. This looks better than before. Updated the instruction. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17720#issuecomment-2065771786 PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1571800082
