On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R <[email protected]> wrote: > Instructions set has been updated as per OS specific. JTable keyboard > navigation is tested in each OS and according it's current implementation the > instructions has been updated (Few has been removed and few has been > updated). > PassFailJFrame.builder is used.
Changes requested by achung (Committer). test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 102: > 100: colorColumn.setCellRenderer(colorColumnRenderer); > 101: > 102: // Set a tooltip for the header of the color's column. I think `Set a tooltip for the header of the color column` would be technically correct? test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 130: > 128: frame.add(scrollPane); > 129: frame.pack(); > 130: frame.setVisible(true); no need for frame.setVisible since PassFailJFrame will do that ------------- PR Review: https://git.openjdk.org/jdk/pull/18855#pullrequestreview-2015214194 PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1575014694 PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1575012265
