On Tue, 23 Apr 2024 06:44:32 GMT, Abhishek Kumar <[email protected]> wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
>> PassFailJFrame.builder is used.
>
> test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 105:
>
>> 103: TableCellRenderer headerRenderer =
>> colorColumn.getHeaderRenderer();
>> 104: if (headerRenderer instanceof DefaultTableCellRenderer)
>> 105: ((DefaultTableCellRenderer)
>> headerRenderer).setToolTipText("Hi Mom!");
>
> Suggestion:
> Usage of enhanced `instanceOf` avoids the casting to
> `DefaultTableCellRenderer` below. Use `{ }` for single if statement too.
>
> Suggestion:
>
> if (colorColumn.getHeaderRenderer() instanceof
> DefaultTableCellRenderer headerRenderer ) {
> headerRenderer.setToolTipText("Hi Mom!");
> }
>
>
> Same can be used at L115 as well.
> `int cellValue = (value instanceof Number number) ? number.intValue() : 0;`
Yeah, updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1575791723
