On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung <ach...@openjdk.org> wrote:
> Updating giflib, clientlibs tests are green on all platforms This giflib update has huge amount of gratuitous reformatting make it hard to spot what is really new. I hope they don't repeat that. src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h line 40: > 38: #include <unistd.h> > 39: #endif > 40: /** End JDK modifications to support building on Windows **/ Do we still need this ? src/java.desktop/share/native/libsplashscreen/giflib/gif_lib.h line 57: > 55: #define true 1 > 56: /** End JDK modifications to support building using old compilers**/ > 57: Do we still need this ? ------------- PR Comment: https://git.openjdk.org/jdk/pull/18985#issuecomment-2080172718 PR Review Comment: https://git.openjdk.org/jdk/pull/18985#discussion_r1581575163 PR Review Comment: https://git.openjdk.org/jdk/pull/18985#discussion_r1581574254
