On Mon, 29 Apr 2024 21:05:34 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h line 40: >> >>> 38: #include <unistd.h> >>> 39: #endif >>> 40: /** End JDK modifications to support building on Windows **/ >> >> Do we still need this ? > > The GIFLIB version 5.2.2 adds the `ifndef` wrap, and it is no longer the "JDK > modification", so it looks like our comment can be removed does this also apply for the other JDK modification for old compilers as well? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18985#discussion_r1585334886
