On Sat, 13 Apr 2024 21:26:35 GMT, Phil Race <p...@openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add output bins support to the common print dialog
>
> src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.java
> line 55:
>
>> 53: public class OutputBin extends EnumSyntax
>> 54: implements DocAttribute, PrintRequestAttribute,
>> PrintJobAttribute {
>> 55:
>
> Not sure I see this as a DocAttribute. We have a couple of dubious
> DocAttributes, but I don't see the bin the output is sent to as a property of
> the document.
>
> Also this class needs to be added to the table here :
> https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/print/attribute/standard/package-summary.html
The fix is updated to remove the DocAttribute and to add the OutputBin class to
the package-summary.
> src/java.desktop/share/classes/javax/print/attribute/standard/OutputBin.java
> line 57:
>
>> 55:
>> 56: /**
>> 57: * Use serialVersionUID from JDK 1.4 for interoperability.
>
> Obviously not the case here. I think you should just delete this comment.
The comment is deleted.
> src/java.desktop/share/classes/sun/print/CustomOutputBin.java line 69:
>
>> 67:
>> 68: /**
>> 69: * Use serialVersionUID from JDK 1.4 for interoperability.
>
> delete comment
The comment is deleted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1586714887
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1586716235
PR Review Comment: https://git.openjdk.org/jdk/pull/16166#discussion_r1586718603
